Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

Upgrade to new version number 0.6.0 #391

Merged
merged 1 commit into from
May 4, 2022
Merged

Upgrade to new version number 0.6.0 #391

merged 1 commit into from
May 4, 2022

Conversation

BrianGun
Copy link
Contributor

@BrianGun BrianGun commented May 4, 2022

Fixes #390

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration(s):

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@BrianGun BrianGun requested a review from galran May 4, 2022 22:58
@codecov-commenter
Copy link

codecov-commenter commented May 4, 2022

Codecov Report

Merging #391 (02915c3) into main (61a99e8) will increase coverage by 0.29%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #391      +/-   ##
==========================================
+ Coverage   54.39%   54.68%   +0.29%     
==========================================
  Files          80       80              
  Lines        8016     7741     -275     
==========================================
- Hits         4360     4233     -127     
+ Misses       3656     3508     -148     
Impacted Files Coverage Δ
src/Optical/OpticalInterface.jl 66.66% <0.00%> (-2.67%) ⬇️
src/RepeatingStructures/HexagonalLattice.jl 53.52% <0.00%> (-2.33%) ⬇️
src/Geometry/Primitives/Curves/BSpline.jl 66.66% <0.00%> (-1.61%) ⬇️
src/Geometry/CSG/Intersection.jl 49.29% <0.00%> (-1.41%) ⬇️
src/OpticSim.jl 87.50% <0.00%> (-1.39%) ⬇️
src/Geometry/Transform.jl 55.34% <0.00%> (-0.83%) ⬇️
src/Geometry/CSG/CSG.jl 83.76% <0.00%> (-0.83%) ⬇️
src/RepeatingStructures/Multilens/HexTilings.jl 56.36% <0.00%> (-0.78%) ⬇️
src/Geometry/Primitives/AsphericSurface.jl 59.39% <0.00%> (-0.73%) ⬇️
src/Geometry/Primitives/Curves/Knots.jl 92.30% <0.00%> (-0.72%) ⬇️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61a99e8...02915c3. Read the comment docs.

@BrianGun BrianGun merged commit 1869a24 into main May 4, 2022
@BrianGun BrianGun deleted the BrianGun/issue390 branch May 4, 2022 23:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to new version number
3 participants