This repository has been archived by the owner on Oct 23, 2022. It is now read-only.
Cluser size and eyebox subdivision can be out of sync #381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #380
modified setup_nominal_system,setup_system, and choosecluster to take a no_eyebox_subdivision keyword argument. Ensured cluster data and eyebox subdivisions are consistent.
Pull Request Template
Description
Cluster size and eyebox subdivisions can be out of sync if the user passes an eyebox subdivision argument to setup_system that is inconsistent with the result that would be returned by choosecluster. This fix allows to user to choose to either have the eyebox subdivided as computed by choosecluster or to have no eyebox subdivisions.
Fixes # (380)
Type of change
How Has This Been Tested?
manually tested several configurations to make sure the correct number of subdivisions was used. All existing unit tests pass.
Test Configuration(s):
Checklist: