Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

Cluser size and eyebox subdivision can be out of sync #381

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

BrianGun
Copy link
Contributor

@BrianGun BrianGun commented Mar 10, 2022

Fixes #380

modified setup_nominal_system,setup_system, and choosecluster to take a no_eyebox_subdivision keyword argument. Ensured cluster data and eyebox subdivisions are consistent.

Pull Request Template

Description

Cluster size and eyebox subdivisions can be out of sync if the user passes an eyebox subdivision argument to setup_system that is inconsistent with the result that would be returned by choosecluster. This fix allows to user to choose to either have the eyebox subdivided as computed by choosecluster or to have no eyebox subdivisions.

Fixes # (380)

Type of change

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

manually tested several configurations to make sure the correct number of subdivisions was used. All existing unit tests pass.

Test Configuration(s):

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [ x] My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my own code
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • [ x] I have made corresponding changes to the documentation
  • [ x] My changes generate no new warnings
  • [ x] I have added tests that prove my fix is effective or that my feature works
  • [ x] New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • [x ] I have checked my code and corrected any misspellings

Fixes #380

modified setup_nominal_system,setup_system, and choosecluster to take a no_eyebox_subdivision keyword argument. Ensured cluster data and eyebox subdivisions are consistent.
@BrianGun BrianGun requested a review from galran March 10, 2022 22:43
@BrianGun BrianGun merged commit 45017e6 into main Mar 11, 2022
@BrianGun BrianGun deleted the BrianGun/issue380 branch March 11, 2022 18:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cluser size and eyebox subdivision can be out of sync
2 participants