This repository has been archived by the owner on Oct 23, 2022. It is now read-only.
BrianGun/issue378 #379
Merged
BrianGun/issue378 #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #376
replaced all references to SCHOTT with hardcoded glasses in both docs and src. Some notebooks are still not working correctly, for other reasons.
…trings to initialize the SurfaceType column.
… and rectangular grid ray patterns that have been replaced by the new Emitters code. Added RayListSource as a first step in making some examples in other_examples.jl work.
…arField and GridField functions.
…ch use the function and will require considerable work to update.
…he other emitters
… work correctly but others still need work. deleted two examples that used the old spot diagram vis code that referenced HexapolarField.
…ted direct reference to fields of source in draw! routines and made the argument type an AbstractSource instead of a concrete Source.
Fixes #376
fixed vistest in Diagnostics.jl so it passes correct argument to RayListSource constructor
Fixes #378
added RGBCluster type to ClusterWithProperties so lenslet eyebox assignment code can determine if eyeboxes need to be assigned across RGB
… and it should have been [2 -4;2 2]. Added extensive documentation to eyebox_numbers added a test for new eyebox numbering that correctly accounts for RGB lenslets.
rewrote eyebox number assignment test as a function.
…tion was moved to Repeat.Multilens.
Codecov Report
@@ Coverage Diff @@
## main #379 +/- ##
==========================================
+ Coverage 54.14% 55.16% +1.01%
==========================================
Files 81 80 -1
Lines 8076 7735 -341
==========================================
- Hits 4373 4267 -106
+ Misses 3703 3468 -235
Continue to review full report at Codecov.
|
galran
approved these changes
Mar 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Fixed incorrect assignment of eyebox number to lenslet arrays with RGB lenslets.
Fixes # (378)
Type of change
How Has This Been Tested?
Created new test for eyebox assignment
Checklist: