BrianGun/issue367

[BrianGun]

Pull Request Template

Description

system_properties function automatically calculated eyebox subdivisions but there are times when the user wants to override this. the code has been rewritten so user can specify eyebox subdivisions.

Fixes # (367)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• [x ] New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

ran unit tests

Checklist:

• [ x] My code follows the style guidelines of this project
• [x ] I have performed a self-review of my own code
• [ x] I have commented my code, particularly in hard-to-understand areas
• [ x] I have made corresponding changes to the documentation
• [ x] My changes generate no new warnings
• [ x] I have added tests that prove my fix is effective or that my feature works
• [ x] New and existing unit tests pass locally with my changes
• [x ] Any dependent changes have been merged and published in downstream modules
• [ x] I have checked my code and corrected any misspellings

[codecov-commenter]

Codecov Report

Merging #374 (558017a) into main (c386906) will increase coverage by 0.37%.
The diff coverage is 52.94%.

@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
+ Coverage   54.17%   54.54%   +0.37%     
==========================================
  Files          81       81              
  Lines        8083     7786     -297     
==========================================
- Hits         4379     4247     -132     
+ Misses       3704     3539     -165     

Impacted Files	Coverage Δ
src/RepeatingStructures/Multilens/Example.jl	0.00% <0.00%> (ø)
...RepeatingStructures/Multilens/LensletAssignment.jl	0.00% <0.00%> (ø)
src/RepeatingStructures/Multilens/Analysis.jl	66.42% <75.00%> (-0.47%)	⬇️
src/RepeatingStructures/HexagonalLattice.jl	66.19% <0.00%> (-2.64%)	⬇️
src/Geometry/Primitives/Curves/BSpline.jl	66.66% <0.00%> (-1.61%)	⬇️
src/Geometry/CSG/Intersection.jl	49.29% <0.00%> (-1.41%)	⬇️
src/OpticSim.jl	87.50% <0.00%> (-1.39%)	⬇️
src/Geometry/Transform.jl	55.34% <0.00%> (-0.83%)	⬇️
src/Geometry/CSG/CSG.jl	83.76% <0.00%> (-0.83%)	⬇️
src/Geometry/Primitives/AsphericSurface.jl	59.39% <0.00%> (-0.73%)	⬇️
... and 52 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57f4e23...558017a. Read the comment docs.