Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

BrianGun/issue365 #366

Merged
merged 3 commits into from
Feb 9, 2022
Merged

BrianGun/issue365 #366

merged 3 commits into from
Feb 9, 2022

Conversation

BrianGun
Copy link
Contributor

@BrianGun BrianGun commented Feb 8, 2022

Fix longstanding warnings related to deprecations and const redefinitions

Description

We've had an increasing backlog of warnings. This PR fixes the ones that come from our code.

Fixes # (365)

Type of change

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

ran unit tests

Checklist:

  • [ x] My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my own code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • [x ] I have made corresponding changes to the documentation
  • [x ] My changes generate no new warnings
  • [x ] I have added tests that prove my fix is effective or that my feature works
  • [x ] New and existing unit tests pass locally with my changes
  • [x ] Any dependent changes have been merged and published in downstream modules
  • [x ] I have checked my code and corrected any misspellings

@BrianGun BrianGun requested a review from galran February 8, 2022 19:42
@BrianGun BrianGun merged commit c386906 into main Feb 9, 2022
@BrianGun BrianGun deleted the BrianGun/issue365 branch February 9, 2022 23:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants