BrianGun/issue336

[BrianGun]

Pull Request Template

Description

changed Transform from a type alias for SMatrix to a struct. The type alias was causing subtle bugs.

Unfortunately these bugs were discovered after I had begun on a different PR to add lenslet assignment code. The two code bases became entwined in a way that is a pain to undo so the PR actually has a mix of code.

Fixes # (i336)

Type of change

• [ x] Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Passed unit test.

Checklist:

• [ x] My code follows the style guidelines of this project
• [ x] I have performed a self-review of my own code
• [ x] I have commented my code, particularly in hard-to-understand areas
• [x ] I have made corresponding changes to the documentation
• [x ] My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• [x ] Any dependent changes have been merged and published in downstream modules
• [x ] I have checked my code and corrected any misspellings

[codecov-commenter]

Codecov Report

Merging #342 (c27b031) into main (00e7822) will decrease coverage by 0.14%.
The diff coverage is 49.27%.

@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
- Coverage   52.51%   52.37%   -0.15%     
==========================================
  Files          83       84       +1     
  Lines        7721     7759      +38     
==========================================
+ Hits         4055     4064       +9     
- Misses       3666     3695      +29     

Impacted Files	Coverage Δ
src/Examples/docs_examples.jl	0.00% <0.00%> (ø)
src/Optical/Lenses.jl	37.06% <0.00%> (ø)
...RepeatingStructures/Multilens/LensletAssignment.jl	0.00% <0.00%> (ø)
src/Vis/VisRepeatingStructures.jl	93.02% <75.00%> (ø)
src/Geometry/Transform.jl	55.34% <86.11%> (+1.96%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00e7822...c27b031. Read the comment docs.