Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

added the InfiniteStopConvexPoly shape to allow aperture for hex lenses. #328

Merged
merged 2 commits into from
Nov 30, 2021

Conversation

galran
Copy link
Collaborator

@galran galran commented Nov 29, 2021

also fixed a small bug in convex polygon assert statement.

also fixed a small bug in convex polygon assert statement.
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2021

Codecov Report

Merging #328 (bb3905e) into main (fdd6374) will increase coverage by 0.04%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
+ Coverage   55.16%   55.21%   +0.04%     
==========================================
  Files          79       79              
  Lines        7287     7299      +12     
==========================================
+ Hits         4020     4030      +10     
- Misses       3267     3269       +2     
Impacted Files Coverage Δ
src/Geometry/Primitives/NonCSG/Stop.jl 57.52% <72.72%> (+0.63%) ⬆️
src/Geometry/Primitives/NonCSG/ConvexPolygon.jl 61.90% <100.00%> (ø)
src/Optical/OpticalSystem.jl 39.56% <0.00%> (+0.31%) ⬆️
src/Geometry/Primitives/Plane.jl 76.36% <0.00%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdd6374...bb3905e. Read the comment docs.

friggog
friggog previously approved these changes Nov 29, 2021
Copy link
Collaborator

@friggog friggog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe should add an allocation test for the new stop just to make sure?

@galran
Copy link
Collaborator Author

galran commented Nov 29, 2021

do i need to add an allocation test explicitly? i thought that they run for all the benchmarks.

@galran
Copy link
Collaborator Author

galran commented Nov 30, 2021

added allocation tests. hope i did it correctly.

@BrianGun BrianGun merged commit bea1205 into main Nov 30, 2021
@BrianGun BrianGun deleted the galran/InfiniteStopConvexPoly branch November 30, 2021 00:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants