Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

add centroid return value to beamenergy #322

Merged
merged 3 commits into from
Nov 12, 2021
Merged

add centroid return value to beamenergy #322

merged 3 commits into from
Nov 12, 2021

Conversation

BrianGun
Copy link
Contributor

@BrianGun BrianGun commented Nov 11, 2021

Pull Request Template

Description

added centroid return value to beamenergy function.

Fixes #321

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

passed unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@BrianGun BrianGun changed the title CompatHelper: add new compat entry for MeshIO at version 0.4, (keep existing compat) (#318) add centroid return value to beamenergy fixes 3321 Nov 11, 2021
@BrianGun BrianGun changed the title add centroid return value to beamenergy fixes 3321 add centroid return value to beamenergy Nov 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2021

Codecov Report

Merging #322 (e5ef743) into main (1661d8b) will increase coverage by 0.01%.
The diff coverage is 62.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
+ Coverage   54.56%   54.58%   +0.01%     
==========================================
  Files          78       78              
  Lines        7079     7081       +2     
==========================================
+ Hits         3863     3865       +2     
  Misses       3216     3216              
Impacted Files Coverage Δ
src/Optical/ParaxialAnalysis/LensletAssembly.jl 60.97% <62.22%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1661d8b...e5ef743. Read the comment docs.

@BrianGun BrianGun merged commit 72a6abf into main Nov 12, 2021
@BrianGun BrianGun deleted the BrianGun/issue321 branch November 12, 2021 18:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return centroid from beamenergy function
3 participants