This repository has been archived by the owner on Oct 23, 2022. It is now read-only.
Brian gun/issue315 fix beam energy calculation #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #315
debugging the fix
galran
approved these changes
Nov 9, 2021
Codecov Report
@@ Coverage Diff @@
## main #316 +/- ##
==========================================
+ Coverage 54.55% 54.56% +0.01%
==========================================
Files 78 78
Lines 7396 7079 -317
==========================================
- Hits 4035 3863 -172
+ Misses 3361 3216 -145
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
beamenergy was computing the wrong value because it was dividing by the area of the pupil rather than the area of the lenslet. This is now fixed.