This repository has been archived by the owner on Oct 23, 2022. It is now read-only.
Brian gun/issue310 lenslet analysis #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #310
added multilens analysis functions
Fixes #310
added function to compute minimum lenslet diameter based on required mtf at give cycles/deg.
…onse when choosing minimum lenslet size. added more informative labels to parameter sweep graphs.
Fixes #310
changed B&W to Monochrome, plot to Plots.plot, imported Plots.
Fixes #310
added function to compute lattice coordinates of a given point if that point is in the span of the lattice basis vectors
Fixes #310
better comments for cyclesperdegree
Codecov Report
@@ Coverage Diff @@
## main #312 +/- ##
==========================================
- Coverage 55.19% 52.51% -2.69%
==========================================
Files 79 83 +4
Lines 7299 7721 +422
==========================================
+ Hits 4029 4055 +26
- Misses 3270 3666 +396
Continue to review full report at Codecov.
|
Fixes #310
added code to compute lattice tiles that intersect a polygonal shape.
Fixes #310
fixed bug in overlappintiles. Was missing some tiles.
rewriting tilevertices and tilesinside to make them more composable and more generic.
galran
previously approved these changes
Nov 25, 2021
fixed project function in DisplayGeneration.jl
…uster given coordinates in the underlying element basis.
…Still needs more testing.
…easons this doesn't work modified spherepolygons to return tile coordinates as well as polygons. These coordinates will be used to compute the properties of the lenslet in a later stage.
…cSim.jl into BrianGun/issue310
galran
approved these changes
Nov 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added functionality to analyze lenslet systems. This is a large PR because it adds significant new functionality, which is difficult to add piecemeal.