Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

Change abstract type Basis to AbstractBasis to be more consistent with our naming convention #307

Merged
merged 4 commits into from
Oct 31, 2021

Conversation

BrianGun
Copy link
Contributor

@BrianGun BrianGun commented Oct 28, 2021

Pull Request Template

Description

Basis is an abstract type. Our convention has been to name these Abstract(typename). Make this match the convention.

Fixes # (306)

Type of change

  • [X ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

name change so existing code that uses Basis will not work.

How Has This Been Tested?

passes all unit tests

Checklist:

  • [x ] My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my own code
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • [x ] I have made corresponding changes to the documentation
  • [x ] My changes generate no new warnings
  • [x ] I have added tests that prove my fix is effective or that my feature works
  • [x ] New and existing unit tests pass locally with my changes
  • [x ] Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@BrianGun BrianGun changed the title Merge branch 'main' of https://github.com/microsoft/OpticSim.jl into main Change abstract type Basis to AbstractBasis to be more consistent with our naming convention Oct 28, 2021
@BrianGun BrianGun requested a review from galran October 28, 2021 22:21
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2021

Codecov Report

Merging #307 (5b8c07d) into main (443cc32) will not change coverage.
The diff coverage is 37.50%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #307   +/-   ##
=======================================
  Coverage   54.53%   54.53%           
=======================================
  Files          78       78           
  Lines        7073     7073           
=======================================
  Hits         3857     3857           
  Misses       3216     3216           
Impacted Files Coverage Δ
...tical/ParaxialAnalysis/HeadEyeModel/Arrangement.jl 0.00% <0.00%> (ø)
src/RepeatingStructures/HexagonalLattice.jl 46.47% <ø> (ø)
src/RepeatingStructures/Lattice.jl 71.42% <0.00%> (ø)
src/RepeatingStructures/RectangularLattice.jl 20.00% <ø> (ø)
src/RepeatingStructures/Cluster.jl 55.17% <33.33%> (ø)
src/Vis/VisRepeatingStructures.jl 93.02% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 443cc32...5b8c07d. Read the comment docs.

@BrianGun BrianGun merged commit bbbd136 into main Oct 31, 2021
@BrianGun BrianGun deleted the BrianGun/issue306 branch October 31, 2021 17:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants