Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

CompatHelper: bump compat for Pluto to 0.16, (keep existing compat) #285

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Pluto package from 0.12, 0.14, 0.15 to 0.12, 0.14, 0.15, 0.16.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@alfredclwong alfredclwong force-pushed the compathelper/new_version/2021-09-10-00-08-59-683-03445472727 branch from 4616562 to 4feee85 Compare September 10, 2021 00:09
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2021

Codecov Report

Merging #285 (4feee85) into main (883d09f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #285   +/-   ##
=======================================
  Coverage   54.46%   54.46%           
=======================================
  Files          78       78           
  Lines        7071     7071           
=======================================
  Hits         3851     3851           
  Misses       3220     3220           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 883d09f...4feee85. Read the comment docs.

@alfredclwong
Copy link
Collaborator

Pluto has had some really nice changes since I last used it! I'll do a quick check with our code in samples/notebooks to make sure everything still works before approving this PR.

@alfredclwong alfredclwong self-assigned this Sep 15, 2021
@alfredclwong alfredclwong self-requested a review September 15, 2021 09:25
Copy link
Collaborator

@alfredclwong alfredclwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notebooks are out of date with OpticSim anyway so this won't hurt

@alfredclwong alfredclwong merged commit 44243b3 into main Sep 15, 2021
@alfredclwong alfredclwong deleted the compathelper/new_version/2021-09-10-00-08-59-683-03445472727 branch September 15, 2021 12:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants