Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

Update documentation to use drawcells instead of drawhexcells #282

Merged
merged 3 commits into from
Sep 8, 2021

Conversation

BrianGun
Copy link
Contributor

@BrianGun BrianGun commented Sep 7, 2021

Fixes #281
Fixes #280

fixed call to Vis.drawcells to use the new interface instead of Vis.drawhexcells

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

verified that documentation has correct figures after the change

Checklist:

  • [ x] My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my own code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [x ] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • [x ] New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • [ x] I have checked my code and corrected any misspellings

Fixes #281

fixed call to Vis.drawcells to use the new interface.
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2021

Codecov Report

Merging #282 (94d3791) into main (98a5b5b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #282   +/-   ##
=======================================
  Coverage   54.46%   54.46%           
=======================================
  Files          78       78           
  Lines        7071     7071           
=======================================
  Hits         3851     3851           
  Misses       3220     3220           
Impacted Files Coverage Δ
src/Vis/VisRepeatingStructures.jl 93.02% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98a5b5b...94d3791. Read the comment docs.

BrianGun and others added 2 commits September 7, 2021 19:53
Fixes #281

updated LatticeBasis call in docs to use new arguments.
Copy link
Collaborator

@alfredclwong alfredclwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@alfredclwong alfredclwong enabled auto-merge (squash) September 8, 2021 09:22
@alfredclwong alfredclwong merged commit ea8a29a into main Sep 8, 2021
@alfredclwong alfredclwong deleted the BrianGun/issue281 branch September 8, 2021 09:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation to use drawcells instead of drawhexcells Repeat docs broken
3 participants