Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

Update SCHOTT and SUMITA sources #278

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Conversation

alfredclwong
Copy link
Collaborator

@alfredclwong alfredclwong commented Sep 6, 2021

The link for SCHOTT has changed slightly, as well as the checksums for both SCHOTT and SUMITA.

Fixes #279 (mostly)

@alfredclwong alfredclwong self-assigned this Sep 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2021

Codecov Report

Merging #278 (fd0a47b) into main (9787980) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
- Coverage   53.96%   53.93%   -0.03%     
==========================================
  Files          78       78              
  Lines        7056     7056              
==========================================
- Hits         3808     3806       -2     
- Misses       3248     3250       +2     
Impacted Files Coverage Δ
src/GlassCat/sources.jl 90.90% <0.00%> (-3.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9787980...fd0a47b. Read the comment docs.

@alfredclwong
Copy link
Collaborator Author

@BrianGun could you review/approve this one asap pls. The SCHOTT update is causing core tests/examples to fail.

@alfredclwong alfredclwong merged commit 61bc687 into main Sep 7, 2021
@alfredclwong alfredclwong deleted the alfred/update-sources branch September 7, 2021 09:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Glass Files Do Not Load
3 participants