Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

color("$c") -> colorant"$c" #275

Merged
merged 2 commits into from
Aug 31, 2021
Merged

color("$c") -> colorant"$c" #275

merged 2 commits into from
Aug 31, 2021

Conversation

alfredclwong
Copy link
Collaborator

color("$c") is deprecated. This is throwing a warning that causes some tests to fail.

@alfredclwong alfredclwong added bug Something isn't working testing Adding missing tests or correcting existing tests labels Aug 31, 2021
@alfredclwong alfredclwong requested a review from BrianGun August 31, 2021 08:59
@alfredclwong alfredclwong self-assigned this Aug 31, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2021

Codecov Report

Merging #275 (6b4480f) into main (351427d) will increase coverage by 0.02%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
+ Coverage   53.93%   53.96%   +0.02%     
==========================================
  Files          78       78              
  Lines        7056     7056              
==========================================
+ Hits         3806     3808       +2     
+ Misses       3250     3248       -2     
Impacted Files Coverage Δ
src/Examples/repeating_structure_examples.jl 28.26% <20.00%> (ø)
src/GlassCat/sources.jl 93.93% <0.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 351427d...6b4480f. Read the comment docs.

@BrianGun BrianGun merged commit 0c3adb9 into main Aug 31, 2021
@BrianGun BrianGun deleted the alfred/fix-repeat-tests branch August 31, 2021 17:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working testing Adding missing tests or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants