This repository has been archived by the owner on Oct 23, 2022. It is now read-only.
BrianGun/issue257 #264
Merged
BrianGun/issue257 #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #257
added cluster lattice
modified latticebasis to use matrix to represent basis vectors instead of SVector{SVector}}. Simpler.
Fixes #257
working on LatticeCluster. LatticeBasis constructor is allocating for obscure reasons. This is probably not a performance issue since this shouldn't be in performance critical parts of the code.
Fixes #257
basic cluster lattices seem to be working. Need to write better visualization code.
Fixes #257
added function to create example LatticeCluster
reworking draw for clusters so it is more sensible.
Fixes #257
incomplete type signature on basis function for LatticeBasis was causing allocations and huge increase in computation. Fixed now.
Fixes #257
variable renaming
Fixes #257
changed draw functions to draw any type of lattice shape not just HexBasis1.
Added Hex12RGB function to make hex12 pattern. Not working yet.
…r lattices so they will draw cell names as well as indices. fixed error in HexBasis3 basis function updated examples so hex drawings work with the new code
Fixes #257
comment change
Fixes #257
removed unused code from VisRepeatingStructures.jl
Codecov Report
@@ Coverage Diff @@
## main #264 +/- ##
==========================================
+ Coverage 53.01% 53.93% +0.92%
==========================================
Files 77 78 +1
Lines 6974 7056 +82
==========================================
+ Hits 3697 3806 +109
+ Misses 3277 3250 -27
Continue to review full report at Codecov.
|
Fixes #257
fixed naming error for file repeating_structure_examples.jl
moved example cluster functions to the example file
added more examples for creating and drawing ClusterWithProperties
|
@galran could you look over this PR and tell me if you think more examples are necessary (look in Examples directory, repeating_structures_examples.jl). |
…ed to require Matrix{2,N}
…ells defined as 2xN matrix instead of SVector of Tuple{Int,Int}
Fixes #257
modified Arrangement.jl to work with lattice functions.
Fixes #257
simplifying get_shapes
galran
approved these changes
Aug 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions to create and manipulate clusters of elements in lattices.
Description
These functions allow you to create repeating clusters of lattice elements.
Fixes # (257)
Type of change
How Has This Been Tested?
created various clusters and verified that they graphed properly.
Checklist: