Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

Downgrade Documenter to "< 0.27" #261

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Downgrade Documenter to "< 0.27" #261

merged 1 commit into from
Aug 10, 2021

Conversation

alfredclwong
Copy link
Collaborator

@alfredclwong alfredclwong commented Aug 9, 2021

something in 0.27 is causing our doc build to hang. not really worth chasing down (i've tried).

@alfredclwong alfredclwong added bug Something isn't working documentation Improvements or additions to documentation labels Aug 9, 2021
@alfredclwong alfredclwong self-assigned this Aug 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2021

Codecov Report

Merging #261 (57795d2) into main (776e788) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
+ Coverage   54.97%   55.05%   +0.07%     
==========================================
  Files          72       72              
  Lines        6708     6699       -9     
==========================================
  Hits         3688     3688              
+ Misses       3020     3011       -9     
Impacted Files Coverage Δ
src/Vis/Visualization.jl 9.01% <0.00%> (+0.14%) ⬆️
src/Geometry/CSG/CSG.jl 83.52% <0.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 776e788...57795d2. Read the comment docs.

@BrianGun
Copy link
Contributor

BrianGun commented Aug 9, 2021

@alfredclwong did this fix the problem? I noticed that all the documentation files are commented out. Does the documentation build when they are uncommented?

@alfredclwong
Copy link
Collaborator Author

@alfredclwong did this fix the problem? I noticed that all the documentation files are commented out. Does the documentation build when they are uncommented?

I've just been chucking a load of scenarios at the server to see what works. Seems like I've found the fix - will clean this up and request a review when it's confirmed.

@alfredclwong alfredclwong changed the title Downgrade Documenter to "< 0.27.5" Downgrade Documenter to "< 0.27" Aug 10, 2021
@alfredclwong alfredclwong enabled auto-merge (squash) August 10, 2021 10:43
@alfredclwong alfredclwong merged commit 4283733 into main Aug 10, 2021
@alfredclwong alfredclwong deleted the fix-docs branch August 10, 2021 17:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants