Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

Fix nightly test failure #252

Merged
merged 4 commits into from
Jul 28, 2021
Merged

Fix nightly test failure #252

merged 4 commits into from
Jul 28, 2021

Conversation

alfredclwong
Copy link
Collaborator

Prepend empty Vis.draw() call to Visualization testset. This prevents the info message from Makie's initial run from triggering the @test_nowarn macro.

For future reference, if we need to ignore @info messages, we can use https://docs.julialang.org/en/v1/stdlib/Test/#Test.@test_logs for greater specificity.

@alfredclwong alfredclwong added the testing Adding missing tests or correcting existing tests label Jul 27, 2021
@alfredclwong alfredclwong self-assigned this Jul 27, 2021
@alfredclwong alfredclwong requested review from BrianGun and galran July 27, 2021 10:41
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2021

Codecov Report

Merging #252 (3900f14) into main (648f685) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
+ Coverage   54.65%   54.78%   +0.12%     
==========================================
  Files          69       69              
  Lines        6495     6495              
==========================================
+ Hits         3550     3558       +8     
+ Misses       2945     2937       -8     
Impacted Files Coverage Δ
src/Vis/Visualization.jl 8.87% <0.00%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 648f685...3900f14. Read the comment docs.

@alfredclwong alfredclwong merged commit 0325967 into main Jul 28, 2021
@alfredclwong alfredclwong deleted the fix-nightly branch July 28, 2021 09:54
alfredclwong added a commit that referenced this pull request Aug 27, 2021
Add `sudo apt-get update` line to the "Install GR dependencies (Linux only)" step. This updates download links to required packages. See #252 #270
@alfredclwong alfredclwong mentioned this pull request Aug 27, 2021
alfredclwong added a commit that referenced this pull request Aug 31, 2021
Add `sudo apt-get update` line to the "Install GR dependencies (Linux only)" step. This updates download links to required packages. See #252 #270
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testing Adding missing tests or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants