Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

Re-add GlassCat.EYE module #249

Merged
merged 3 commits into from
Jul 27, 2021
Merged

Re-add GlassCat.EYE module #249

merged 3 commits into from
Jul 27, 2021

Conversation

alfredclwong
Copy link
Collaborator

Had to dig this up from the old repo and move from AGF to OTHER. Should be useful for upcoming eye stuff. Also required for current eye model.

@alfredclwong alfredclwong requested a review from BrianGun July 26, 2021 14:18
@alfredclwong alfredclwong self-assigned this Jul 26, 2021
@BrianGun
Copy link
Contributor

@alfredclwong CARGILLE is not defined which is causing all the tests to fail.

@alfredclwong
Copy link
Collaborator Author

@alfredclwong CARGILLE is not defined which is causing all the tests to fail.

Missed this, thanks. Should be fixed now.

@alfredclwong alfredclwong requested a review from galran July 27, 2021 10:41
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2021

Codecov Report

Merging #249 (67fc63c) into main (d89b6fc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #249   +/-   ##
=======================================
  Coverage   54.68%   54.68%           
=======================================
  Files          69       69           
  Lines        6494     6494           
=======================================
  Hits         3551     3551           
  Misses       2943     2943           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d89b6fc...67fc63c. Read the comment docs.

@BrianGun BrianGun merged commit 26ce17e into main Jul 27, 2021
@BrianGun BrianGun deleted the eye-data branch July 27, 2021 18:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants