This repository has been archived by the owner on Oct 23, 2022. It is now read-only.
Luxor figures in documenter #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…: png and svg to better support the docs creation.
Codecov Report
@@ Coverage Diff @@
## latticeExtensions #235 +/- ##
=====================================================
- Coverage 55.69% 55.64% -0.06%
=====================================================
Files 74 74
Lines 6544 6550 +6
=====================================================
Hits 3645 3645
- Misses 2899 2905 +6
Continue to review full report at Codecov.
|
BrianGun
approved these changes
Jul 16, 2021
BrianGun
added a commit
that referenced
this pull request
Jul 20, 2021
* Extensions to existing lattic code. * adding code for repeating structures * rewrote lattice functions. Much simpler now. * generalized lattice type so it works in any dimension * optimized LatticeBasis constructor by tweaking type annotation. 50x faster than before. * documentation changes in Lattice.jl * documentation change in Lattice.jl * added const ring1 ring2 definitions using diagonal arrows which Julia is not accepting as variable names. * added code to Lattice.jl to create the 1 and 2 ring hex patterns. * added hex to ring1,ring2 function names * small simplifications to hexring functions in Lattice.jl * changing lattice rings to generate both i,j indices of ring hexagons and positions of centers. * changed hexring functions to generate i,j coordinate offsets rather than absolute x,y positions for ring hex centers. More convenient for indexing into a hexagon array. * comment change * doc change * generalizing hexagonal lattice code so up down, etc. work regardless of basis. * new hex code simplies bases and ring calculation. * moved using statements from Visualization.jl to Vis.jl because Vis.jl defines the module. * added VisRepeatingStructures.jl * added hexgrid visualization code. Fixed hex basis errors. * comment change * got ring1 and ring2 hexagons working and rewrote hexpoints to work with i,j coordinates rather than 2D points. * simplifying ring function to make it completely general. * last offset in hexcycle was hexdownleft() should have been hexdownright() * made hexcycle const * changed hexcellsinbox to return a 1D array and added color option to drawhexcells * documentation change * cleaned up code gave hex lattice functions more informative names, better doc strings, removed unused functions. * working on documentation for repeating structures. * changed hexup(), etc. to take a number of steps arg. This will be useful for computing the centers of ring n hexagonal clusters. * more name changes and doc changes * scaled text to be proportional to size of hex cell so it is more readable. improved color choice when user doesn't specify colors. changed function names in HexagonalLattice.jl to be more descriptive. * added license notice * added license header * added examples for repeating structures. changed docs to include neighbors and basis as part of the interface of the Basis abstract type. * added license line * example code change * modified Vis.jl file to have same import/usings as used to be in Visualization.jl * updated comment in Vis.jl about precompiled sysimage * fixed examples for repeating structures. * Update docs/make.jl Co-authored-by: Charlie Hewitt <[email protected]> * file name change, hexregion -> region(::LatticeBasis...) first crack at Repeating structures documentation. * tweaking repeat documentation * added tilevertices to interface for lattice so vertices of unit tile are associated with the lattice basis vectors. * removed call to Vis.save because that only works with Makie, not Luxor. * updated project.toml to makie 0.14.2 * documentation for repeating structures module. * repeat structure documentation improvements. * documentation improvements for repeat * more doc improvements for repeat * typo in repeat documentation * fixes to repeat documentation * documentation changes for repeat * added Luxor to project.toml in docs project. small changes to vis of hex cells. * example illustrations for repeat didn't show up because forgot to use full package name. * type in repeat docs * typo in repeat docs. Visualization doesn't return luxor drawing properly. Not obvious how to do this. * adding VSCodeCounter directory to .gitignore * added .VSCodeCounter directory to .gitignore * added the bility to produce a repeatable drawing in different formats: png and svg to better support the docs creation. (#235) * removed Luxor from the docs project and fixed the Vis.drawhexcells to support the native julia way of displaying a drawing by using the Luxor.preview function which will return a drawing that will be drawn according to the correct context. (#245) Co-authored-by: Charlie Hewitt <[email protected]> Co-authored-by: Ran Gal <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added the ability to produce a repeatable drawing in different formats: png and svg to better support the docs creation.
@BrianGun take a look at the examples in repeat.md