This repository has been archived by the owner on Oct 23, 2022. It is now read-only.
fixing the nightly builds #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… generator (UniformCone) and the rangom rectangle position generator (RectUniform). this l allow us to define the correct generator using the tests regardless of any changes to the default random generator in the future.
Codecov Report
@@ Coverage Diff @@
## main #231 +/- ##
==========================================
+ Coverage 56.53% 56.54% +0.01%
==========================================
Files 68 68
Lines 6444 6444
==========================================
+ Hits 3643 3644 +1
+ Misses 2801 2800 -1
Continue to review full report at Codecov.
|
… fixed the tests to use the specific generator we are expecting.
galran
changed the title
BrianGun
approved these changes
Jul 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added the capability to supply a random generator to random direction generator (UniformCone) and the random rectangle position generator (RectUniform).
Added random generator to Spectrum.Uniform too.
Modified the emiiters tests to use the specific random number generator to produce trhe expected results.
this will allow us to define the correct generator using the tests regardless of any changes to the default random generator in the future.