-
Notifications
You must be signed in to change notification settings - Fork 40
Conversation
Codecov Report
@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 44.58% 49.42% +4.84%
==========================================
Files 59 53 -6
Lines 7131 6116 -1015
==========================================
- Hits 3179 3023 -156
+ Misses 3952 3093 -859
Continue to review full report at Codecov.
|
@alfredclwong Deleting Spectra.jl is okay. Deleting Miscellaneous.jl is okay. There is just one example in there that is useful. I sent it to you and Ran in email. Don't remove the precompile file. It executes some visualization code during precompilation that makes time to first render faster. Makes a noticeable difference. The build task in VSCode doesn't do this. I have some ideas about what we could do that might make this more seamless. I'll create a new issue. The reason I stopped using it was because Julia Computing support hypothesized that some corrupt type information generated during the precompilation caused by the precompile file was causing an obscure bug in our code. But we haven't had any trouble like that for a while so it was probably a transient thing. If you modify your commit to undo the rm of the precompile file I'll ok the pull request. |
These changes are just suggestions - I'm putting them into a PR for review/discussion.
@BrianGun I remember you saying that you don't use our custom Precompile/Sysimage code anymore - if this is the case, should we clean these files? Similarly, I don't see usages for Miscellaneous.jl (aka Junk) or Spectra.jl. Let me know if they're still here for a reason and I'll revert the specific commits.
Specifying a separate test/Project.toml helps us to lighten the core dependency list.
The big change: I think Benchmarks, Diagnostics and TestData naturally belong in test/. Some docs/examples use TestData, but otherwise they're largely separate from the core functionality and they take up a good chunk of compile time. We can just include($path_to_TestData) for the few exceptions, as I've done here. What do you guys think?