Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

draw_stackedbeamsplitters uses old leaf(...) function instead of new transform(...) function to apply a transform to a CSG node. #220

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

BrianGun
Copy link
Contributor

@BrianGun BrianGun commented Jul 5, 2021

Pull Request Template

Description

deterministic ray tracing example wasn't working because draw_stackedbeamsplitters uses the old leaf(...) function to apply a transform to a CSG node rather than the new transform() function.

Fixes # (219)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Ran Documenter to create the documentation for the code and verified that the illustrations were correctly generated.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

…transform(...) function to apply a transform to a CSG node.

Fixes #219
@BrianGun BrianGun requested review from friggog and galran July 5, 2021 19:09
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2021

Codecov Report

Merging #220 (1c437ab) into main (83171f3) will decrease coverage by 0.89%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
- Coverage   56.55%   55.66%   -0.90%     
==========================================
  Files          67       65       -2     
  Lines        6372     6327      -45     
==========================================
- Hits         3604     3522      -82     
- Misses       2768     2805      +37     
Impacted Files Coverage Δ
src/Examples/docs_examples.jl 0.00% <0.00%> (ø)
src/Geometry/Primitives/Qtype.jl 75.00% <0.00%> (-8.34%) ⬇️
src/Optical/LensAssembly.jl 48.93% <0.00%> (-7.24%) ⬇️
src/Optical/Emitters/Emitters.jl 75.00% <0.00%> (-5.00%) ⬇️
src/Optical/OpticalInterface.jl 63.23% <0.00%> (-4.30%) ⬇️
src/Geometry/CSG/Intersection.jl 48.57% <0.00%> (-2.14%) ⬇️
src/Geometry/Geometry.jl 0.00% <0.00%> (-2.05%) ⬇️
src/GlassCat/sources.jl 90.90% <0.00%> (-1.82%) ⬇️
src/Geometry/Primitives/Curves/BSpline.jl 66.15% <0.00%> (-0.52%) ⬇️
src/Geometry/CSG/CSG.jl 83.20% <0.00%> (-0.38%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83171f3...1c437ab. Read the comment docs.

@BrianGun BrianGun merged commit 4e32790 into main Jul 5, 2021
@BrianGun BrianGun deleted the BrianGun/issue219 branch July 5, 2021 19:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants