This repository has been archived by the owner on Oct 23, 2022. It is now read-only.
Support Makie’s modern interface – removed explicit references to AbstractPlotting and MakieLayout #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 2, 2021 13:36
…tting and Makie Layout modules inside makie as they are removed since Makie version 0.13. Still need to change the samples but I want to check it agains the new makie version to see the effect.
Codecov Report
@@ Coverage Diff @@
## main #214 +/- ##
==========================================
- Coverage 56.58% 56.55% -0.03%
==========================================
Files 67 67
Lines 6366 6372 +6
==========================================
+ Hits 3602 3604 +2
- Misses 2764 2768 +4
Continue to review full report at Codecov.
|
BrianGun
approved these changes
Jul 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove explicit references to the AbstractPlotting and Makie Layout modules inside makie as they are removed since Makie version 0.13.
I check the changes against Makie 0.13.4 and 0.14.2.
Compilation wise it was fine but i did notice some weird changes in Makie's scaling of objects. Rays with scale factor of 0.2 appear bigger then everything in the scene. Will need to handle it when we upgrade to a newer Makie.