Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

Fix Source constructor #186

Merged
merged 2 commits into from
May 13, 2021
Merged

Fix Source constructor #186

merged 2 commits into from
May 13, 2021

Conversation

alfredclwong
Copy link
Collaborator

Expose Type{T} to the other default arguments in the constructor

Fixes #185

Expose `Type{T}` to the other default arguments in the constructor

Fixes #185
@alfredclwong alfredclwong added the bug Something isn't working label May 13, 2021
@alfredclwong alfredclwong requested a review from BrianGun May 13, 2021 18:25
@alfredclwong alfredclwong self-assigned this May 13, 2021
@alfredclwong alfredclwong enabled auto-merge (squash) May 13, 2021 18:39
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2021

Codecov Report

Merging #186 (1da7370) into main (20ddd28) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 1da7370 differs from pull request most recent head 5faaeaf. Consider uploading reports for the commit 5faaeaf to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
- Coverage   56.71%   56.65%   -0.07%     
==========================================
  Files          67       67              
  Lines        6381     6381              
==========================================
- Hits         3619     3615       -4     
- Misses       2762     2766       +4     
Impacted Files Coverage Δ
src/Optical/Emitters/Sources.jl 95.89% <ø> (ø)
src/Optical/Fresnel.jl 96.10% <0.00%> (-1.30%) ⬇️
src/Optical/OpticalSystem.jl 37.22% <0.00%> (-0.64%) ⬇️
src/Optical/LensAssembly.jl 55.55% <0.00%> (-0.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1353315...5faaeaf. Read the comment docs.

@alfredclwong alfredclwong merged commit 13844d1 into main May 13, 2021
@alfredclwong alfredclwong deleted the fix/sources branch May 13, 2021 19:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sources.Source constructor will crash if given a type that is other than Float64
3 participants