This repository has been archived by the owner on Oct 23, 2022. It is now read-only.
Replace lingering generateray() calls #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #166
This comment has been minimized.
This comment has been minimized.
|
@alfredclwong this was an oversight. Don't think the multithreaded code is that hard to test, at least to make sure that the code doesn't crash when you run it.
|
BrianGun
approved these changes
May 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some lingering calls to
generateray, which is from the old Emitters API, in thetracefunction. It seems that the same functionality can be achieved with the new API by doing the following replacement:generateray(sources, k)->sources[k]@galran could you confirm?
On a side note, this means that none of our multithreaded trace functions are being tested (confirmed here https://codecov.io/gh/microsoft/OpticSim.jl/src/main/src/Optical/OpticalSystem.jl#L376). @BrianGun is this because it was particularly difficult to test multithreaded code, or did we just skip it?