Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

add_agf changes and tests #177

Merged
merged 4 commits into from
May 7, 2021
Merged

add_agf changes and tests #177

merged 4 commits into from
May 7, 2021

Conversation

alfredclwong
Copy link
Collaborator

Changes

  • Increase robustness of add_agf by adding more checks to the name argument.
  • Add a testset for sources.jl

Note: the TODOs are left as low priority items for later. Currently focusing on the UI work.

@alfredclwong alfredclwong self-assigned this May 7, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2021

Codecov Report

Merging #177 (fad4e08) into main (69b8b74) will increase coverage by 0.78%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   56.01%   56.79%   +0.78%     
==========================================
  Files          66       66              
  Lines        6352     6358       +6     
==========================================
+ Hits         3558     3611      +53     
+ Misses       2794     2747      -47     
Impacted Files Coverage Δ
src/GlassCat/sources.jl 89.09% <87.09%> (+89.09%) ⬆️
src/GlassCat/generate.jl 88.65% <100.00%> (ø)
src/Optical/LensAssembly.jl 56.17% <0.00%> (+0.61%) ⬆️
src/Optical/OpticalSystem.jl 35.89% <0.00%> (+0.64%) ⬆️
src/Optical/Fresnel.jl 97.40% <0.00%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69b8b74...fad4e08. Read the comment docs.

@alfredclwong alfredclwong enabled auto-merge (squash) May 7, 2021 16:31
@alfredclwong alfredclwong merged commit 5b41bf6 into main May 7, 2021
@alfredclwong alfredclwong deleted the alfred/glasscat-tests branch May 7, 2021 21:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants