This repository has been archived by the owner on Oct 23, 2022. It is now read-only.
Removing functions zero3 and one3. #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #157
added a few tests for Transform. Simplified the transform code somewhat.
Codecov Report
@@ Coverage Diff @@
## main #159 +/- ##
==========================================
- Coverage 50.71% 49.86% -0.85%
==========================================
Files 66 64 -2
Lines 6470 6421 -49
==========================================
- Hits 3281 3202 -79
- Misses 3189 3219 +30
Continue to review full report at Codecov.
|
src/Geometry/Transform.jl
Outdated
| @@ -163,6 +147,7 @@ Transform(rotation::AbstractArray{S,2}, translation::AbstractArray{S,1}) | |||
| Transform{T} = SMatrix{4,4,T,16} | |||
| export Transform | |||
|
|
|||
| lastrow(::Type{T}) where{T<:Real} = SMatrix{1,4,T}(zero(T),zero(T),zero(T),one(T)) | |||
There was a problem hiding this comment.
how about lastrow(::Type{T} = Float64) to conform with the rest of the code in Transform.jl?
i'll probably revisit these convenience functions later as i think they could be a little more systematic, but this is fine for now
There was a problem hiding this comment.
lastrow was only being used in one place so I removed the function and inlined it.
Fixes #157
removed lastrow function and inlined it since it was only used in one place.
alfredclwong
approved these changes
Apr 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed zero3,one3,zero4,one4. Julia already provides the zero and ones functions that have equivalent functionality.
Simplified some of the Transform functions.
Fixes # (157)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
wrote tests to verify that the new Transform functions generated the correct matrices and added these tests to our unit test set.
Test Configuration(s):
Checklist: