This repository has been archived by the owner on Oct 23, 2022. It is now read-only.
src/GlassCat/generate.jl tests #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfredclwong
added
bug
also fix incorrect TEST_GLASSES test
Codecov Report
@@ Coverage Diff @@
## main #143 +/- ##
==========================================
- Coverage 48.37% 47.55% -0.82%
==========================================
Files 65 64 -1
Lines 6659 6614 -45
==========================================
- Hits 3221 3145 -76
- Misses 3438 3469 +31
Continue to review full report at Codecov.
|
alfredclwong
changed the title
alfredclwong
commented
Apr 23, 2021
|
@friggog and @alfredclwong is this PR ready to merge? A conversation doesn't seem resolved. |
|
@BrianGun I haven't yet resolved Charlie's comment on the new |
|
didn't mean to rush anybody. Just wanted to make sure this wasn't forgotten. |
alfredclwong
commented
Apr 26, 2021
friggog
previously approved these changes
Apr 26, 2021
this better reflects the desired usage for the new feature (described further in the added docstring line)
alfredclwong
force-pushed
the
fix-glasscat-parsing
branch
from
3a24ce6 to
ffbd1ab
Compare
friggog
approved these changes
Apr 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing GlassCat test sets are a little jumbled.
@testset "Parsing Tests"parses an AGF fileTEST_CAT.agfinto a Julia Dictcat, but then only checks the first glass' values.@testset "Module Gen Tests"then checks the generatedAGF_TEST_CAT.jlagainstcat, which creates a dependency on the previous test set.@testset "Glass Tests"then uses a glass from theTEST_CATmodule, which also creates a dependency on the previous test set.Reorganising these and extending the range of checked values to all 4 glasses catches a couple of odd behaviours that have snuck into GlassCat (mostly due to changes that I've made).
I'll fix these before opening the PR for review.Changes
const AGF_GLASSESetc.