Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

Missed some occurrences of OpticalSystem which should be changed to AbstractOpticalSystem #142

Merged
merged 2 commits into from
Apr 23, 2021

Conversation

BrianGun
Copy link
Contributor

@BrianGun BrianGun commented Apr 22, 2021

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

ran unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov-commenter

This comment has been minimized.

@alfredclwong
Copy link
Collaborator

@BrianGun for future reference, if you want PRs like this to be merged ASAP, you can set up the merge (e.g. Squash and merge) in advance by using the same button. This can be done before any reviews or checks.

@BrianGun BrianGun merged commit dd60ad1 into main Apr 23, 2021
@BrianGun BrianGun deleted the BrianGun/issue138 branch April 23, 2021 16:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants