Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

[WIP] New feature: add AGF sources #111

Merged
merged 6 commits into from
Apr 14, 2021
Merged

[WIP] New feature: add AGF sources #111

merged 6 commits into from
Apr 14, 2021

Conversation

alfredclwong
Copy link
Collaborator

@alfredclwong alfredclwong commented Apr 14, 2021

Fixes #107

Main commit is e9c1936.

Defines GlassCat.add_agf(sourcefile::AbstractString; name::Maybe{AbstractString} = nothing, rebuild::Bool = true), which allows the user to add custom AGF files to sources.txt at runtime. These will then be incorporated into AGFGlassCat.jl on the next rebuild.

TODO:

  • Write tests for old (and new) GlassCat build functions
  • Update docs to reflect changes [PREVIEW]
  • Receive feedback

@alfredclwong alfredclwong force-pushed the feature-add-sources branch 3 times, most recently from 128f611 to 52aac9f Compare April 14, 2021 16:29
@alfredclwong alfredclwong self-assigned this Apr 14, 2021
@alfredclwong alfredclwong added enhancement New feature or request documentation Improvements or additions to documentation labels Apr 14, 2021
@BrianGun
Copy link
Contributor

Will we ever want catalog names that are not purely alphabetical? I can extend the regex to match alphanumeric names with a non-numeric leading character.

for now alphabetical is fine.

@BrianGun BrianGun merged commit 82685d7 into main Apr 14, 2021
@BrianGun BrianGun deleted the feature-add-sources branch April 14, 2021 23:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Robust handling of glass catalog changes
2 participants