Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

Commit

Permalink
Poor performance of ray generation in Emitters.jl because of abstract…
Browse files Browse the repository at this point in the history
… struct field

Fixes #207

removed BenchmarkTools dependency from OpticSim.
  • Loading branch information
BrianGun committed Jun 25, 2021
1 parent 913bbf4 commit 430eb32
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 21 deletions.
1 change: 0 additions & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ repository = "https://github.com/microsoft/OpticSim.jl"
version = "0.5.1"

[deps]
BenchmarkTools = "6e4b80f9-dd63-53aa-95a3-0cdb28fa8baf"
CSV = "336ed68f-0bac-5ca0-87d4-7b16caf5d00b"
ColorSchemes = "35d6a980-a343-548e-a6ea-1d62b119f2f4"
ColorTypes = "3da002f7-5984-5a60-b8a6-cbb66c0b333f"
Expand Down
19 changes: 0 additions & 19 deletions test/TestData/TestData.jl
Original file line number Diff line number Diff line change
Expand Up @@ -17,27 +17,8 @@ using Unitful
using Images
using Base: @.
using LinearAlgebra
using BenchmarkTools


### Emitters

function RectGridAllocations()
directions = Emitters.Directions.RectGrid/4, π/4, 150, 150)
function f()
let result
for point in directions
result = point
end
return result
end
end

result = @benchmark $f()
return result
# return allocations(result)
end

### CURVES

function bsplinecurve()
Expand Down
1 change: 0 additions & 1 deletion test/testsets/Emitters.jl
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ using Test
using OpticSim
using OpticSim.Emitters
using OpticSim.Geometry
using BenchmarkTools

using Random
using StaticArrays
Expand Down

0 comments on commit 430eb32

Please sign in to comment.