-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release libs v1.4.0-preview3 #997
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the property name in the dicriminator
for a unified and concise bug report
Bumps [SharpYaml](https://github.com/xoofx/SharpYaml) from 1.9.2 to 2.1.0. - [Release notes](https://github.com/xoofx/SharpYaml/releases) - [Changelog](https://github.com/xoofx/SharpYaml/blob/master/changelog.md) - [Commits](xoofx/SharpYaml@1.9.2...2.1.0) --- updated-dependencies: - dependency-name: SharpYaml dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…riting either as allOf
…ceding step has failed
…eature-template Adds an issue and feature template
Bump SharpYaml from 1.9.2 to 2.1.0
Fixes Missing Release Notes
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 17.9.0 to 17.10.0. - [Release notes](https://github.com/VerifyTests/Verify/releases) - [Commits](VerifyTests/Verify@17.9.0...17.10.0) --- updated-dependencies: - dependency-name: Verify.Xunit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…17.10.0 Bump Verify.Xunit from 17.9.0 to 17.10.0
…ation Fix anyOf and oneOf v2 serialization
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 17.10.0 to 17.10.2. - [Release notes](https://github.com/VerifyTests/Verify/releases) - [Commits](VerifyTests/Verify@17.10.0...17.10.2) --- updated-dependencies: - dependency-name: Verify.Xunit dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…ator-issue Fix parent schema discriminator validation
…17.10.2 Bump Verify.Xunit from 17.10.0 to 17.10.2
…Api document and its property values
Compute hash of OpenApi document
Cater for file content transferred with base64 encoding
Attach changelog labels for improved release notes experience
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.3.0 to 17.3.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v17.3.0...v17.3.1) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
….Test.Sdk-17.3.1 Bump Microsoft.NET.Test.Sdk from 17.3.0 to 17.3.1
…t-format-property-V3
Retrieve format property during V2 serialization
MaggieKimani1
requested review from
irvinesunday,
darrelmiller,
peombwa,
zengin,
baywet and
millicentachieng
as code owners
September 2, 2022 11:59
Comment on lines
+127
to
+135
if ((!childItem.Properties?.ContainsKey(discriminatorName) ?? false) && | ||
(!childItem.Required?.Contains(discriminatorName) ?? false)) | ||
{ | ||
return ValidateChildSchemaAgainstDiscriminator(childItem, discriminatorName); | ||
} | ||
else | ||
{ | ||
return true; | ||
} |
Check notice
Code scanning / CodeQL
Missed ternary opportunity
Both branches of this 'if' statement return - consider using '?' to express intent better.
Bump lib versions
baywet
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.