Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release libs v1.4.0-preview3 #997

Merged
merged 59 commits into from
Sep 2, 2022
Merged

Release libs v1.4.0-preview3 #997

merged 59 commits into from
Sep 2, 2022

Conversation

MaggieKimani1
Copy link
Contributor

No description provided.

MaggieKimani1 and others added 30 commits July 21, 2022 17:14
for a unified and concise bug report
Bumps [SharpYaml](https://github.com/xoofx/SharpYaml) from 1.9.2 to 2.1.0.
- [Release notes](https://github.com/xoofx/SharpYaml/releases)
- [Changelog](https://github.com/xoofx/SharpYaml/blob/master/changelog.md)
- [Commits](xoofx/SharpYaml@1.9.2...2.1.0)

---
updated-dependencies:
- dependency-name: SharpYaml
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
…eature-template

Adds an issue and feature template
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 17.9.0 to 17.10.0.
- [Release notes](https://github.com/VerifyTests/Verify/releases)
- [Commits](VerifyTests/Verify@17.9.0...17.10.0)

---
updated-dependencies:
- dependency-name: Verify.Xunit
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…17.10.0

Bump Verify.Xunit from 17.9.0 to 17.10.0
…ation

Fix anyOf and oneOf v2 serialization
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 17.10.0 to 17.10.2.
- [Release notes](https://github.com/VerifyTests/Verify/releases)
- [Commits](VerifyTests/Verify@17.10.0...17.10.2)

---
updated-dependencies:
- dependency-name: Verify.Xunit
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
…ator-issue

Fix parent schema discriminator validation
…17.10.2

Bump Verify.Xunit from 17.10.0 to 17.10.2
MaggieKimani1 and others added 19 commits August 24, 2022 14:58
Cater for file content transferred with base64 encoding
Attach changelog labels for improved release notes experience
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.3.0 to 17.3.1.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](microsoft/vstest@v17.3.0...v17.3.1)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
….Test.Sdk-17.3.1

Bump Microsoft.NET.Test.Sdk from 17.3.0 to 17.3.1
Retrieve format property during V2 serialization
Comment on lines +127 to +135
if ((!childItem.Properties?.ContainsKey(discriminatorName) ?? false) &&
(!childItem.Required?.Contains(discriminatorName) ?? false))
{
return ValidateChildSchemaAgainstDiscriminator(childItem, discriminatorName);
}
else
{
return true;
}

Check notice

Code scanning / CodeQL

Missed ternary opportunity

Both branches of this 'if' statement return - consider using '?' to express intent better.
@MaggieKimani1 MaggieKimani1 merged commit c382c22 into master Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants