-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace JsonSchema with OpenApiSchema #1787
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6d32cc1.
…ookups in the component registry
# Conflicts: # src/Microsoft.OpenApi/Models/OpenApiSchema.cs
…ookups in the component registry
…ft/OpenAPI.NET into mk/use-json-schema-model
MaggieKimani1
requested review from
irvinesunday,
darrelmiller,
coseguera,
millicentachieng and
andrueastman
as code owners
August 20, 2024 14:44
src/Microsoft.OpenApi/Models/References/OpenApiSchemaReference.cs
Dismissed
Show dismissed
Hide dismissed
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
darrelmiller
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
JsonSchema.NET
library from the core and Readers projectJsonSchema
object fromJsonSchema.NET
with our nativeOpenApiSchema
implementation that supports all V2, V3, and V31-specific keywords.pattern properties
keyword in line with JSON schema.examples
keyword in theOpenApiSchema
object in line with JSON schema as theexample
property has been deprecated in favor of it.$ref
to$id
by:id
as a locator when registering schemas in the registry and performing lookups during reference resolution.OpenApiSchemaReference
object that acts as a proxy for lazy schema reference resolutionJsonNode
in place ofOpenApiAny
for Enums and ExamplesIssues resolved
#1789
#1790
#1791
#1792
#1793