Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enables NRT, analysis all and treat warning as errors on hidi #1344

Merged
merged 4 commits into from
Sep 19, 2023

Conversation

baywet
Copy link
Member

@baywet baywet commented Sep 14, 2023

    • enables NRT for main hidi project
    • enables all mode analysis

Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @baywet.

There is a trimming warning that is causing the release build to fail due to dotnet/runtime#59230. I believe we should probably suppress/fix before the merge.

config.GetSection(nameof(OpenApiConvertSettings)).Bind(settings);

@baywet
Copy link
Member Author

baywet commented Sep 18, 2023

@andrueastman, thanks. I went the other way around by disabling trimming since fixing it would represent significant work until the source generators are available, and suppressing it means broken functionality.

@sonarcloud
Copy link

sonarcloud bot commented Sep 18, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

79.6% 79.6% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@baywet baywet merged commit a82b00f into vnext Sep 19, 2023
10 of 13 checks passed
@baywet baywet deleted the feature/NRT branch September 19, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants