[Feature] Adds ability to change the response or request body content media type based on custom annotation properties #500

irvinesunday · 2024-03-02T20:49:23Z

Fixes #405

This PR:

Introduces two new custom annotation properties: RequestContentTypes and ResponseContentTypes to help provide means of generating expected request body and response content media types for a given endpoint. The current default is application/json
Updates generation of request body and response content media types of entity sets whose entities have media streams to either generate the annotated media type from the annotated Org.OData.Core.V1.AcceptableMediaTypes or default to application/octet-stream and not generate the application/json media type.
Adds and updates tests to validate the above.
Updates release notes.

…tions

Remove test that checked for application/json key in request body content. If EntitySet.EntityType().HasStream, the annotated media type or default application/octet-stream should be used as the media type.

…ns-props

sonarqubecloud · 2024-03-02T20:54:01Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.2% Coverage on New Code
0.7% Duplication on New Code

See analysis details on SonarCloud

andrueastman

👍🏼

irvinesunday added 15 commits March 1, 2024 14:45

Refactor out common methods

314fd40

Fetch annotated content MIME types

6ad86a2

Remove unnecessary whitespace

bdb74d0

Add custom properties

69518a2

Update tests and integration test file

46168f9

Add custom annotation properties

3f80c94

Don't add Json media type if has stream; check request content annota…

a4127d5

…tions

Retrieve annotated request content types for entity update

ec8f314

Update/add unit tests and update test file

128855f

Rename variable

4aa9816

Add null guard

ff1bfb7

Add and update test

0f5dd4e

Remove test that checked for application/json key in request body content. If EntitySet.EntityType().HasStream, the annotated media type or default application/octet-stream should be used as the media type.

Add test; minor refactorings; comment updates

3eef1e4

Merge remote-tracking branch 'origin/master' into is/custom-annotatio…

e172b0e

…ns-props

Update release notes

66e76eb

irvinesunday self-assigned this Mar 2, 2024

irvinesunday requested review from xuzhg, darrelmiller, peombwa, zengin, baywet, millicentachieng and andrueastman as code owners March 2, 2024 20:49

irvinesunday requested review from MaximRouiller and garethj-msft March 2, 2024 20:50

andrueastman approved these changes Mar 4, 2024

View reviewed changes

irvinesunday merged commit f251ea9 into master Mar 4, 2024
12 checks passed

irvinesunday deleted the is/custom-annotations-props branch March 4, 2024 13:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature] Adds ability to change the response or request body content media type based on custom annotation properties #500

[Feature] Adds ability to change the response or request body content media type based on custom annotation properties #500

irvinesunday commented Mar 2, 2024

sonarqubecloud bot commented Mar 2, 2024

andrueastman left a comment

[Feature] Adds ability to change the response or request body content media type based on custom annotation properties #500

[Feature] Adds ability to change the response or request body content media type based on custom annotation properties #500

Conversation

irvinesunday commented Mar 2, 2024

sonarqubecloud bot commented Mar 2, 2024

Quality Gate passed

andrueastman left a comment

Choose a reason for hiding this comment