Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fixes inconsistency of nullability of schemas of properties that are a collection of structured types #480

Merged
merged 8 commits into from
Jan 25, 2024

Conversation

irvinesunday
Copy link
Contributor

Fixes #467

This PR:

  • Ensures that schemas of properties of collection of complex types are consistent with those of entity types, such that:
identities:
  type: array
  items:
    anyOf:
      - $ref: '#/components/schemas/microsoft.graph.objectIdentity'
      - type: object
         nullable: true

should be...

identities:
  type: array
  items:
    $ref: '#/components/schemas/microsoft.graph.objectIdentity'

[NB] Collection of structured types are not nullable.

  • Updates tests
  • Updates release notes

Copy link

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marvelous!

@irvinesunday irvinesunday merged commit d5e10af into master Jan 25, 2024
12 checks passed
@irvinesunday irvinesunday deleted the is/collections-nullability branch January 25, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nullability information for properties that are collections of complex or entity types is inconsistent
2 participants