Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Updates the format of the request body schema of a collection of complex property #472

Merged
merged 5 commits into from
Jan 16, 2024

Conversation

irvinesunday
Copy link
Contributor

@irvinesunday irvinesunday commented Jan 12, 2024

Fixes #423

This PR:

  • Updates the format of the request body schema of a collection of complex property
  • Updates tests to validate the above
  • Updates tests for Get complex property description and summary to be retrieved from the ReadRestriction annotation.
  • Updates release notes

Copy link

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: to avoid duplication of the collection definitions, we could make them reusable schema like we do for collections of entities

@irvinesunday irvinesunday merged commit 205cff3 into master Jan 16, 2024
12 checks passed
@irvinesunday irvinesunday deleted the is/complex-paths-requestBodies branch January 16, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect request body schema for PUT '/servicePrincipals/{servicePrincipal-id}/synchronization/secrets'
4 participants