Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- adds primary message to error generation #419

Merged
merged 2 commits into from
Sep 5, 2023
Merged

- adds primary message to error generation #419

merged 2 commits into from
Sep 5, 2023

Conversation

baywet
Copy link
Member

@baywet baywet commented Sep 1, 2023

@baywet baywet enabled auto-merge September 1, 2023 19:12
andrueastman
andrueastman reviewed Sep 4, 2023
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just needs a version bump.

@baywet baywet force-pushed the feature/x-ms-primary-error-message branch from a71891d to 4b9f7e0 Compare September 5, 2023 18:12
@baywet
Copy link
Member Author

baywet commented Sep 5, 2023

Looks good to me. Just needs a version bump.

done

@baywet baywet requested a review from andrueastman September 5, 2023 18:12
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

84.2% 84.2% Coverage
0.0% 0.0% Duplication

@baywet baywet merged commit 0971117 into master Sep 5, 2023
@baywet baywet deleted the feature/x-ms-primary-error-message branch September 5, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

@xuzhg xuzhg Awaiting requested review from xuzhg

@irvinesunday irvinesunday Awaiting requested review from irvinesunday

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@peombwa peombwa Awaiting requested review from peombwa

@zengin zengin Awaiting requested review from zengin

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baywet @andrueastman