New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes casing for innerError property in MainError #393

Merged

andrueastman merged 2 commits into master from andrueastman/fixdefaultCasing

Jun 14, 2023

Member

andrueastman commented Jun 14, 2023

Related to microsoftgraph/msgraph-sdk-dotnet#1916

This fixes the casing in the default property name for innerError. This leads to generation of models with the property as innererror causing failing deserialization of the property and therefore the property moved to the additionalData.

Additionally, the metadata defines the property as being camelCased while the generated openApi results in the property name as innererror

<Property Name="innerError" Type="graph.publicInnerError">
  <Annotation Term="Org.OData.Core.V1.Description" String="Details of the inner error." />
</Property>

andrueastman added 2 commits

June 14, 2023 15:52


          Fix typo in default property name

1d614ba


          Bumps version

e3a242a

andrueastman requested review from xuzhg, irvinesunday, darrelmiller, peombwa, zengin, baywet and millicentachieng as code owners

June 14, 2023 13:02

andrueastman enabled auto-merge

June 14, 2023 13:02

baywet approved these changes

View reviewed changes

andrueastman self-assigned this

sonarqubecloud bot commented Jun 14, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

andrueastman merged commit 9bc5d29 into master

andrueastman deleted the andrueastman/fixdefaultCasing branch

June 14, 2023 13:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

baywet baywet approved these changes

xuzhg Awaiting requested review from xuzhg

irvinesunday Awaiting requested review from irvinesunday

darrelmiller Awaiting requested review from darrelmiller

peombwa Awaiting requested review from peombwa

zengin Awaiting requested review from zengin

millicentachieng Awaiting requested review from millicentachieng

Labels

None yet