Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uses SemVerVersion in place of Version to Get or Set the metadata version in the OpenAPI document #360

Merged
merged 10 commits into from
Mar 22, 2023
Merged

Uses SemVerVersion in place of Version to Get or Set the metadata version in the OpenAPI document #360

merged 10 commits into from
Mar 22, 2023

Conversation

irvinesunday
Copy link
Contributor

Fixes #346

@irvinesunday irvinesunday self-assigned this Mar 21, 2023
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

baywet
baywet requested changes Mar 22, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this!

src/Microsoft.OpenApi.OData.Reader/OpenApiConvertSettings.cs Outdated Show resolved Hide resolved
src/Microsoft.OpenApi.OData.Reader/OpenApiConvertSettings.cs Outdated Show resolved Hide resolved
src/Microsoft.OpenApi.OData.Reader/OpenApiConvertSettings.cs Outdated Show resolved Hide resolved
src/Microsoft.OpenApi.OData.Reader/OpenApiConvertSettings.cs Show resolved Hide resolved
baywet
baywet requested changes Mar 22, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes, one last thing

@irvinesunday
Copy link
Contributor Author

Thanks for making the changes, one last thing

@baywet, what last thing?

baywet
baywet approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why my comment didn't make it through, made the change myself

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

64.3% 64.3% Coverage
0.0% 0.0% Duplication

@irvinesunday irvinesunday merged commit 793abf8 into master Mar 22, 2023
@irvinesunday irvinesunday deleted the feature/is/add-semverversion branch March 22, 2023 18:15
@baywet
Copy link
Member

baywet commented Mar 22, 2023

@irvinesunday can you update hidi to take a version parameter please? and update the weekly generation process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@xuzhg xuzhg Awaiting requested review from xuzhg

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@peombwa peombwa Awaiting requested review from peombwa

@zengin zengin Awaiting requested review from zengin

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

Assignees

@irvinesunday irvinesunday

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The OpenAPI version field is not limited to dotnet version specs
2 participants
@irvinesunday @baywet