Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds $value segment to paths with entity types with base types with HasStream=true #358

Merged
merged 4 commits into from
Mar 21, 2023

Conversation

irvinesunday
Copy link
Contributor

Fixes #314

This PR:

  • Append a $value segment if base type of entity type has stream and does not contain a structural property named content
  • Updates tests.

@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

baywet
baywet previously approved these changes Mar 20, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@irvinesunday irvinesunday merged commit d0ec4f3 into master Mar 21, 2023
@irvinesunday irvinesunday deleted the fix/is/base-type-hasStream branch March 21, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hasStream / $value attribute should be propagated to derived types
2 participants