Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate odata.nextLink and odata.deltaLink properties on delta functions response schemas #290

Merged
merged 10 commits into from
Oct 6, 2022
Merged

Generate odata.nextLink and odata.deltaLink properties on delta functions response schemas #290

merged 10 commits into from
Oct 6, 2022

Conversation

millicentachieng
Copy link
Member

@millicentachieng millicentachieng commented Oct 3, 2022 •
edited
Loading

Fixes #285

This PR

  • Renames setting from RefBaseCollectionPaginationCountResponse to EnableODataAnnotationReferencesForResponses to make it apply for all the control information in the response i.e. @odata.nextLink, @odata.deltaLink and @odata.count in our case
  • Adds @odata.nextLink for all actions and functions that return a collection if EnablePagination = true
  • Creates referenceable schema named BaseDeltaFunctionResponse if there's at least one delta function in the model and EnableODataAnnotationReferencesForResponses = true
  • References BaseDeltaFunctionResponse schema for delta functions if EnableODataAnnotationReferencesForResponses = true
  • Adds @odata.nextLink and @odata.deltaLink properties to responses of delta functions if EnableODataAnnotationReferencesForResponses = false

EnableODataAnnotationReferencesForResponses = false
image

EnableODataAnnotationReferencesForResponses = true
image

@millicentachieng millicentachieng force-pushed the fix/ma/delta-functions-next-delta-links-properties branch from 8ac1544 to f06367a Compare October 3, 2022 07:28
@millicentachieng millicentachieng marked this pull request as ready for review October 3, 2022 08:37
@millicentachieng millicentachieng self-assigned this Oct 3, 2022
@millicentachieng millicentachieng force-pushed the fix/ma/delta-functions-next-delta-links-properties branch from 6a08475 to 736a33b Compare October 4, 2022 11:31
@millicentachieng millicentachieng force-pushed the fix/ma/delta-functions-next-delta-links-properties branch from 73b5044 to e26a0d7 Compare October 5, 2022 16:53
@millicentachieng millicentachieng merged commit b9e2a2a into master Oct 6, 2022
@millicentachieng millicentachieng deleted the fix/ma/delta-functions-next-delta-links-properties branch October 6, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@xuzhg xuzhg Awaiting requested review from xuzhg

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@peombwa peombwa Awaiting requested review from peombwa

@zengin zengin Awaiting requested review from zengin

@irvinesunday irvinesunday Awaiting requested review from irvinesunday

Assignees

@millicentachieng millicentachieng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

delta functions are not generating next and delta links properties
3 participants
@millicentachieng @baywet @irvinesunday