-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate duplicated request bodies and responses for actions/functions #266
Merged
millicentachieng
merged 8 commits into
master
from
ma/duplicated-action-function-schemas
Sep 8, 2022
Merged
Eliminate duplicated request bodies and responses for actions/functions #266
millicentachieng
merged 8 commits into
master
from
ma/duplicated-action-function-schemas
Sep 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millicentachieng
changed the title
Eliminate duplicated request bodies for actions
Eliminate duplicated request bodies and responses for actions/functions
Sep 2, 2022
baywet
requested changes
Sep 2, 2022
src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiRequestBodyGenerator.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiRequestBodyGenerator.cs
Outdated
Show resolved
Hide resolved
millicentachieng
force-pushed
the
ma/duplicated-action-function-schemas
branch
from
September 2, 2022 18:08
90b6a94
to
dddfb34
Compare
millicentachieng
requested review from
xuzhg,
irvinesunday,
darrelmiller,
peombwa and
zengin
as code owners
September 2, 2022 18:14
baywet
requested changes
Sep 2, 2022
test/Microsoft.OpenAPI.OData.Reader.Tests/Resources/TripService.OpenApi.yaml
Outdated
Show resolved
Hide resolved
… into ma/duplicated-action-function-schemas
millicentachieng
force-pushed
the
ma/duplicated-action-function-schemas
branch
from
September 5, 2022 12:13
5ccc472
to
94f8aac
Compare
millicentachieng
force-pushed
the
ma/duplicated-action-function-schemas
branch
from
September 5, 2022 12:20
94f8aac
to
d0a5930
Compare
irvinesunday
reviewed
Sep 6, 2022
irvinesunday
reviewed
Sep 6, 2022
src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiResponseGenerator.cs
Show resolved
Hide resolved
irvinesunday
reviewed
Sep 6, 2022
src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiResponseGenerator.cs
Show resolved
Hide resolved
src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiResponseGenerator.cs
Show resolved
Hide resolved
irvinesunday
reviewed
Sep 6, 2022
test/Microsoft.OpenAPI.OData.Reader.Tests/Generator/OpenApiResponseGeneratorTests.cs
Show resolved
Hide resolved
irvinesunday
reviewed
Sep 6, 2022
test/Microsoft.OpenAPI.OData.Reader.Tests/Resources/TripService.OpenApi.V2.json
Show resolved
Hide resolved
baywet
requested changes
Sep 6, 2022
src/Microsoft.OpenApi.OData.Reader/Operation/EdmActionOperationHandler.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.OpenAPI.OData.Reader.Tests/Resources/Multiple.Schema.OpenApi.V2.yaml
Show resolved
Hide resolved
irvinesunday
approved these changes
Sep 8, 2022
baywet
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #241