Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaces instances of anyOf to oneOf #264

Merged
merged 27 commits into from
Sep 8, 2022
Merged

Replaces instances of anyOf to oneOf #264

merged 27 commits into from
Sep 8, 2022

Conversation

irvinesunday
Copy link
Contributor

Fixes #245

This PR:

  • Replaces anyOf to oneOf for geometric points.
  • Replaces instances of anyOf to oneOf for Decimal, Double, Single and Int64 EdmPrimitiveTypeKind.
  • Updates unit and integration tests.
  • Make components for floating point numbers.

@irvinesunday irvinesunday requested a review from xuzhg as a code owner August 18, 2022 08:48
@irvinesunday irvinesunday self-assigned this Aug 18, 2022
baywet
baywet requested changes Aug 18, 2022
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this, a couple of remarks

src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiEdmTypeSchemaGenerator.cs Outdated Show resolved Hide resolved
src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiEdmTypeSchemaGenerator.cs Outdated Show resolved Hide resolved
src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiEdmTypeSchemaGenerator.cs Outdated Show resolved Hide resolved
baywet
baywet requested changes Aug 24, 2022
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I missed the affectation

src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiSchemaGenerator.cs Show resolved Hide resolved
src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiSchemaGenerator.cs Outdated Show resolved Hide resolved
@baywet
Copy link
Member

baywet commented Sep 8, 2022

I think some unit tests still need to be updated and we should be good to go after that.

@irvinesunday
Remove collectionFormat from integration test files
e4f6489 
This is because `Explode = false` for the OData query parameters.
@irvinesunday irvinesunday enabled auto-merge (squash) September 8, 2022 13:22
@irvinesunday irvinesunday merged commit cd5b900 into master Sep 8, 2022
@irvinesunday irvinesunday deleted the fix/is/anyOf-oneOf-inversion branch September 8, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@xuzhg xuzhg Awaiting requested review from xuzhg

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@peombwa peombwa Awaiting requested review from peombwa

@zengin zengin Awaiting requested review from zengin

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

Assignees

@irvinesunday irvinesunday

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

translation to anyOf and oneOf has been inverted throughout the conversion process
2 participants
@irvinesunday @baywet