Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds @odata.type property and makes this a required property in schemas that have discriminator objects #246

Merged
merged 5 commits into from
Jul 5, 2022

Conversation

irvinesunday
Copy link
Contributor

Fixes #243

This PR does the following:

Given an example of this schema, which is a base type, which exposes the discriminator mappings as shown:

MicrosoftTeams-image (2)

The following is accomplished:

  1. Adds the @odata.type property in the properties' object
  2. Marks the @odata.type property as required
  3. In the @odata.type property, sets the default value to '#microsoft.graph.entity
  4. Updates tests to validate the above.

After the above, the schema should appear as below:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discriminator object refers to missing property
2 participants