Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include correct list of discriminator information #222

Merged
merged 5 commits into from
May 30, 2022
Merged

Include correct list of discriminator information #222

merged 5 commits into from
May 30, 2022

Conversation

millicentachieng
Copy link
Member

@millicentachieng millicentachieng commented May 26, 2022 •
edited
Loading

Fixes #219

Retrieve list of derived types for structured types and adds it to the mapping property of the discriminator object.

@millicentachieng millicentachieng changed the title Retrieve list of derived types for structured types Include correct list of discriminator information May 26, 2022
@millicentachieng millicentachieng marked this pull request as ready for review May 26, 2022 14:50
@millicentachieng millicentachieng requested a review from baywet May 26, 2022 14:51
baywet
baywet requested changes May 26, 2022
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank for taking this on.
On top of the suggestion, please add an entry in the changelog in the csproj.

src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiSchemaGenerator.cs Outdated Show resolved Hide resolved
baywet
baywet previously approved these changes May 27, 2022
View reviewed changes
irvinesunday
irvinesunday previously approved these changes May 27, 2022
View reviewed changes
@millicentachieng millicentachieng enabled auto-merge (squash) May 27, 2022 12:49
@irvinesunday irvinesunday disabled auto-merge May 27, 2022 12:56
@millicentachieng millicentachieng dismissed stale reviews from irvinesunday and baywet via a0d8dd7 May 27, 2022 13:42
@baywet baywet requested a review from irvinesunday May 27, 2022 16:35
@irvinesunday irvinesunday merged commit 816d30f into master May 30, 2022
@irvinesunday irvinesunday deleted the is/discriminator-value-fix branch May 30, 2022 04:59
@baywet
Copy link
Member

baywet commented May 30, 2022

@irvinesunday @millicentachieng FYI I just approved the CD, the nuget should be available in 10 minutes

@irvinesunday
Copy link
Contributor

@irvinesunday @millicentachieng FYI I just approved the CD, the nuget should be available in 10 minutes

@baywet, we weren't intending to get 1.0.11-preview1 out yet with just this fix. There were a couple of other fixes that were meant to go out 1st before we do the release.

@baywet
Copy link
Member

baywet commented May 30, 2022

ah... sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irvinesunday irvinesunday irvinesunday approved these changes

@baywet baywet baywet approved these changes

@xuzhg xuzhg Awaiting requested review from xuzhg

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

Assignees

@millicentachieng millicentachieng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discriminator information is incomplete
3 participants
@millicentachieng @baywet @irvinesunday