Fixes generation of ODataTypeCast paths
#212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzhg
reviewed
Apr 25, 2022
|
Others look good to me |
baywet
previously approved these changes
May 2, 2022
baywet
force-pushed
the
is/fix-ODataTypeCast-paths
branch
from
e9d42ea to
7cb1058
Compare
baywet
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #199
This PR:
CreateTypeCastPaths()instead of the entity type declaring the navigation property.ExpandDerivedTypesNavigationPropertiesthat can be used to evaluate whether or not to expand derived types navigation properties. When this setting is set totrue, we end up generating over 219K paths for the beta version of Graph (with a maximum of 1 type cast segment allowed in a path). This is because we have deeply nested derived types in our metadata. This needs to be set tofalsewhen generating OpenAPI documents for Graph. Trying to limit the number of type cast segments in a path does not help much. As described above, limiting the number of type cast segments in a path to 1 leads to a path count of over 219K (using the Graph beta integration test file in the test project). All this while ensuring circular generation of type cast segments is avoided and only ensuring unique type cast segments in the path.Utils.csclass.