Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sets the response type of functions returning Edm.Stream to application/octet-stream #211

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Sets the response type of functions returning Edm.Stream to application/octet-stream #211

merged 3 commits into from
Apr 20, 2022

Conversation

irvinesunday
Copy link
Contributor

Fixes #200

This PR:

  • Sets the response types of functions returning Edm.Stream from application/json to application/octet-stream.
  • Updates unit test and integration file to validate the above.

@irvinesunday irvinesunday requested review from peombwa and baywet April 19, 2022 21:04
@irvinesunday irvinesunday self-assigned this Apr 19, 2022
@irvinesunday irvinesunday merged commit 7234041 into master Apr 20, 2022
@irvinesunday irvinesunday deleted the is/octet-stream-media-type branch April 20, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrelmiller darrelmiller darrelmiller approved these changes

@peombwa peombwa Awaiting requested review from peombwa

@baywet baywet Awaiting requested review from baywet

@xuzhg xuzhg Awaiting requested review from xuzhg

Assignees

@irvinesunday irvinesunday

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Functions that return Edm.Stream are not being correctly converted
2 participants
@irvinesunday @darrelmiller