Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PUT operation on entity sets and navigation properties based on UpdateMethod annotation #166

Merged
merged 10 commits into from
Feb 8, 2022

Conversation

danielmbaluka
Copy link
Contributor

@danielmbaluka danielmbaluka commented Jan 27, 2022

Fixes #106
Fixes microsoftgraph/microsoft-graph-devx-api#607

This PR adds support for PUT operations for entity sets , navigation properties and complex types based on the annotated Http method in the UpdateMethod property of Org.OData.Capabilities.V1.UpdateRestrictions annotation for a given target element.

See: https://github.com/oasis-tcs/odata-vocabularies/blob/053724df1ab5d19cc198f2a52cf8a85a2be08d79/vocabularies/Org.OData.Capabilities.V1.xml#L676-L677

@danielmbaluka danielmbaluka force-pushed the feature/dm/add-support-for-put-operations branch 2 times, most recently from bcd3569 to df01079 Compare January 31, 2022 05:32
@danielmbaluka danielmbaluka changed the title support put operations on entities through update restrictions Add support for PUT operation on entity sets and navigation properties based on UpdateMethod annotation Jan 31, 2022
@danielmbaluka danielmbaluka marked this pull request as ready for review January 31, 2022 07:37
@baywet baywet added this to the 1.0.10 milestone Jan 31, 2022
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe ComplexProperty cases need to be updated as well.
Also, it'd be good to have an example in trip service integration files.

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking in the changes, one last thing.

docs/csdl/TripService.xml Show resolved Hide resolved
@danielmbaluka danielmbaluka force-pushed the feature/dm/add-support-for-put-operations branch from ba5fdd5 to 6c8395b Compare February 3, 2022 11:50
@danielmbaluka
Copy link
Contributor Author

thanks for taking in the changes, one last thing.

@baywet thank you for review, please take another look.

baywet
baywet previously approved these changes Feb 3, 2022
@danielmbaluka danielmbaluka force-pushed the feature/dm/add-support-for-put-operations branch from 6c8395b to 10e0007 Compare February 6, 2022 15:32
irvinesunday
irvinesunday previously approved these changes Feb 8, 2022
@danielmbaluka danielmbaluka force-pushed the feature/dm/add-support-for-put-operations branch from a57bff1 to 045d631 Compare February 8, 2022 10:28
@danielmbaluka danielmbaluka merged commit 9183c9a into master Feb 8, 2022
@danielmbaluka danielmbaluka deleted the feature/dm/add-support-for-put-operations branch February 8, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for PUT operations based on annotations Add support for PUT operations based on annotations
3 participants